Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undeterministic upload tests #1430

Merged
merged 5 commits into from
Feb 9, 2021
Merged

Undeterministic upload tests #1430

merged 5 commits into from
Feb 9, 2021

Conversation

refs
Copy link
Member

@refs refs commented Feb 2, 2021

Why?

As a developer creating/maintaining a storage driver I want to be able to validate the atomicity of all my storage driver operations.

  • Test for: Start 2 uploads, pause the first one, let the second one finish first, resume the first one at some point in time. Both uploads should finish. Needs to result in 2 versions, last finished is the most recent version.
  • Test for: Start 2 MKCOL requests with the same path, one needs to fail.

This PR only shows faulty functionality. When working on a fix on a red/green basis, remove the test build tag and fix the code on the storage layer.

@refs refs requested a review from labkode as a code owner February 2, 2021 11:44
@refs refs requested review from butonic, IljaN and ishank011 February 2, 2021 11:44
IljaN
IljaN approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@IljaN IljaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Great research!

ishank011
ishank011 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ishank011 ishank011 merged commit f57cfe5 into cs3org:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishank011 ishank011 ishank011 approved these changes

@IljaN IljaN IljaN approved these changes

@labkode labkode Awaiting requested review from labkode

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@refs @IljaN @ishank011